Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep existing package name when migrating #1791

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Keep existing package name when migrating #1791

merged 1 commit into from
Nov 25, 2022

Conversation

BenSurgisonGDS
Copy link
Contributor

No description provided.

@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch from d141c9a to 1796a55 Compare November 18, 2022 15:53
@BenSurgisonGDS BenSurgisonGDS changed the base branch from main to v13 November 18, 2022 16:22
@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch from 1796a55 to 086d1b9 Compare November 22, 2022 11:00
@BenSurgisonGDS BenSurgisonGDS changed the base branch from v13 to main November 23, 2022 18:58
@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch 2 times, most recently from eab4c14 to b03e716 Compare November 24, 2022 14:50
lfdebrux
lfdebrux reviewed Nov 25, 2022
View reviewed changes
bin/cli Outdated Show resolved Hide resolved
lfdebrux
lfdebrux reviewed Nov 25, 2022
View reviewed changes
bin/cli Outdated Show resolved Hide resolved
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review November 25, 2022 12:51
@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch 2 times, most recently from 8a2470d to 63293c7 Compare November 25, 2022 13:21
lfdebrux
lfdebrux reviewed Nov 25, 2022
View reviewed changes
__tests__/spec/migrate.js
@@ -44,6 +44,28 @@ describe('migrate test prototype', () => {
})
})

it('package.json', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lfdebrux lfdebrux changed the title Retain original package name property Keep package name when migrating existing prototypes Nov 25, 2022
@lfdebrux lfdebrux changed the title Keep package name when migrating existing prototypes Keep existing package name when migrating Nov 25, 2022
@lfdebrux
Copy link
Member

Oh we should add this to the changelog

@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch from 63293c7 to a7ffd8c Compare November 25, 2022 14:25
@BenSurgisonGDS BenSurgisonGDS force-pushed the retain-original-package-name-property branch from b0bd8a0 to 7edb0ec Compare November 25, 2022 14:29
@BenSurgisonGDS BenSurgisonGDS merged commit 5e2f79e into main Nov 25, 2022
@BenSurgisonGDS BenSurgisonGDS deleted the retain-original-package-name-property branch November 25, 2022 14:46
@lfdebrux lfdebrux mentioned this pull request Dec 6, 2022
Merged
@lfdebrux lfdebrux added this to the v13.0.1 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfdebrux lfdebrux lfdebrux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v13.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenSurgisonGDS @lfdebrux